Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Adjust dark theme to be accessible adjust cypress tests #41948

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 30, 2023

Summary

  1. Adjust the dark theme colors a bit to have the required contrast for accessibility.
  2. Move accessibility cypress test to e2e so all themes can be tested.

Basically on dark mode all status colors had to be made a bit brighter, on bright mode only the warning color failed the tests for the blurry background (but only a little adjustment was needed).

before after
Screenshot_20231130_233725 Screenshot_20231201_010020
Screen Shot 2023-12-01 at 01 06 16 Screen Shot 2023-12-01 at 01 05 26
Screen Shot 2023-12-01 at 01 06 05 Screen Shot 2023-12-01 at 01 05 05
Screen Shot 2023-12-01 at 01 08 21 Screen Shot 2023-12-01 at 01 08 45

Checklist

Also fix warning text color for bright / default theme on blurry background

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/accessibility-dark-mode branch from 464b56c to da346aa Compare November 30, 2023 23:59
@susnux
Copy link
Contributor Author

susnux commented Dec 1, 2023

BTW unrelated but I noticed that the highcontrast themes are not fulfilling WCAG AAA contrast. I think that should be changed?

@susnux susnux requested a review from szaimen December 1, 2023 00:03
@susnux
Copy link
Contributor Author

susnux commented Dec 1, 2023

/backport to stable28

@susnux susnux merged commit aa30452 into master Dec 6, 2023
48 of 51 checks passed
@susnux susnux deleted the fix/accessibility-dark-mode branch December 6, 2023 16:50
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants