Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] enh(settings): Load from disabled users endpoint #41949

Merged
merged 3 commits into from
Dec 6, 2023
Merged

[stable28] enh(settings): Load from disabled users endpoint #41949

merged 3 commits into from
Dec 6, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 1, 2023

@Pytal Pytal added bug 3. to review Waiting for reviews labels Dec 1, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Dec 1, 2023
@Pytal Pytal self-assigned this Dec 1, 2023
@Pytal Pytal enabled auto-merge December 1, 2023 00:39
nickvergessen
nickvergessen approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈
But didn't check if pagination works properly when you have 100 disabled users and start searching for a user starting with z

@blizzz blizzz mentioned this pull request Dec 1, 2023
Merged
5 tasks
@Pytal Pytal force-pushed the backport/stable28/40169 branch 2 times, most recently from 9c11e2d to 6a51725 Compare December 5, 2023 21:58
Pytal and others added 3 commits December 6, 2023 00:08
@Pytal @AndyScherzinger
enh(settings): Load from disabled users endpoint
c7fc085 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 7affbba)
@Pytal @AndyScherzinger
chore: compile assets
e32d383 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc @AndyScherzinger
Invert parameter order in getDisabledUserList to be consistent
a9d86c1 
This matches what was done in the calls and so fixes getting disabled
 user list when there are several backends returning disabled users.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 85e7887)
@AndyScherzinger AndyScherzinger force-pushed the backport/stable28/40169 branch from 6a51725 to a9d86c1 Compare December 5, 2023 23:08
@AndyScherzinger AndyScherzinger merged commit b10f72f into stable28 Dec 6, 2023
49 of 50 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/stable28/40169 branch December 6, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @nickvergessen @AndyScherzinger @artonge @come-nc