Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(out-of-office): Add OCS endpoint to set and clear absence #41957

Merged
merged 3 commits into from
Dec 1, 2023
Merged

feat(out-of-office): Add OCS endpoint to set and clear absence #41957

merged 3 commits into from
Dec 1, 2023

Conversation

nickvergessen
Copy link
Member

TODO

  • Add OCS endpoint so that clients can set this in the future
  • Migrate frontend to OCS endpoint
  • Remove unused index.php endpoint

Checklist

@nickvergessen
feat(out-of-office): Add OCS endpoint to set and clear absence
6eef5c9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(out-of-office): Migrate frontend to OCS endpoint
2abf8e9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Dec 1, 2023
@nickvergessen nickvergessen self-assigned this Dec 1, 2023
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Dec 1, 2023
provokateurin
provokateurin approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAPI looks good

ChristophWurst
ChristophWurst approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ChristophWurst ChristophWurst requested a review from st3iny December 1, 2023 08:30
@nickvergessen
fix(out-of-office)!: Remove non OCS endpoint
2ff3a3c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/41458/add-ocs-endpoint-for-setting-ooo branch from 02e7f6e to 2ff3a3c Compare December 1, 2023 08:46
@nickvergessen
Copy link
Member Author

Had forgotten the autoloader update on the removal commit, force pushed that:

diff --git a/apps/dav/composer/composer/autoload_classmap.php b/apps/dav/composer/composer/autoload_classmap.php
index ef28133ed06..5d6b077ad53 100644
--- a/apps/dav/composer/composer/autoload_classmap.php
+++ b/apps/dav/composer/composer/autoload_classmap.php
@@ -193,7 +193,6 @@ return array(
     'OCA\\DAV\\Connector\\Sabre\\SharesPlugin' => $baseDir . '/../lib/Connector/Sabre/SharesPlugin.php',
     'OCA\\DAV\\Connector\\Sabre\\TagList' => $baseDir . '/../lib/Connector/Sabre/TagList.php',
     'OCA\\DAV\\Connector\\Sabre\\TagsPlugin' => $baseDir . '/../lib/Connector/Sabre/TagsPlugin.php',
-    'OCA\\DAV\\Controller\\AvailabilitySettingsController' => $baseDir . '/../lib/Controller/AvailabilitySettingsController.php',
     'OCA\\DAV\\Controller\\BirthdayCalendarController' => $baseDir . '/../lib/Controller/BirthdayCalendarController.php',
     'OCA\\DAV\\Controller\\DirectController' => $baseDir . '/../lib/Controller/DirectController.php',
     'OCA\\DAV\\Controller\\InvitationResponseController' => $baseDir . '/../lib/Controller/InvitationResponseController.php',
diff --git a/apps/dav/composer/composer/autoload_static.php b/apps/dav/composer/composer/autoload_static.php
index 73e680ef2e8..2456604a9cb 100644
--- a/apps/dav/composer/composer/autoload_static.php
+++ b/apps/dav/composer/composer/autoload_static.php
@@ -208,7 +208,6 @@ class ComposerStaticInitDAV
         'OCA\\DAV\\Connector\\Sabre\\SharesPlugin' => __DIR__ . '/..' . '/../lib/Connector/Sabre/SharesPlugin.php',
         'OCA\\DAV\\Connector\\Sabre\\TagList' => __DIR__ . '/..' . '/../lib/Connector/Sabre/TagList.php',
         'OCA\\DAV\\Connector\\Sabre\\TagsPlugin' => __DIR__ . '/..' . '/../lib/Connector/Sabre/TagsPlugin.php',
-        'OCA\\DAV\\Controller\\AvailabilitySettingsController' => __DIR__ . '/..' . '/../lib/Controller/AvailabilitySettingsController.php',
         'OCA\\DAV\\Controller\\BirthdayCalendarController' => __DIR__ . '/..' . '/../lib/Controller/BirthdayCalendarController.php',
         'OCA\\DAV\\Controller\\DirectController' => __DIR__ . '/..' . '/../lib/Controller/DirectController.php',
         'OCA\\DAV\\Controller\\InvitationResponseController' => __DIR__ . '/..' . '/../lib/Controller/InvitationResponseController.php',

@nickvergessen nickvergessen merged commit 1ca7ba7 into master Dec 1, 2023
49 of 51 checks passed
@nickvergessen nickvergessen deleted the feat/41458/add-ocs-endpoint-for-setting-ooo branch December 1, 2023 09:24
@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen nickvergessen mentioned this pull request Dec 1, 2023
Merged
@nickvergessen
Copy link
Member Author

Backport in #41963

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement feature: dav
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Out of office: expose setting endpoint via OCS
3 participants
@nickvergessen @ChristophWurst @provokateurin