feat(Updater/Admin): Clarify instructions for upgrade.disable-web to avoid confusion/reduce help requests/help downstream Docker image maintainers
#41971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile |
|
/compile amend / |
nextcloud-command
force-pushed
the
enh/upgrade-disable-web-instructions
branch
from
0a5f7c3 to
36762d0
Compare
joshtrichards
added
3. to review
joshtrichards
changed the title
upgrade.disable-web to avoid confusion/reduce help requests/help downstream Docker image mainaintersupgrade.disable-web to avoid confusion/reduce help requests/help downstream Docker image maintainters
susnux
approved these changes
Dec 1, 2023
susnux
requested review from
a team,
nfebe,
sorbaugh and
emoral435
and removed request for
a team
joshtrichards
changed the title
upgrade.disable-web to avoid confusion/reduce help requests/help downstream Docker image maintaintersupgrade.disable-web to avoid confusion/reduce help requests/help downstream Docker image maintainers
emoral435
approved these changes
Dec 1, 2023
|
/compile amend/ |
Signed-off-by: Josh Richards <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
enh/upgrade-disable-web-instructions
branch
from
36762d0 to
f909520
Compare
kesselb
reviewed
Dec 2, 2023
| @@ -56,7 +56,7 @@ | |||
| class="button" | |||
| :class="{ hidden: !updaterEnabled }">{{ t('updatenotification', 'Download now') }}</a> | |||
| <span v-if="updaterEnabled && !webUpdaterEnabled"> | |||
| {{ t('updatenotification', 'Please use the command line updater to update.') }} | |||
| {{ t('updatenotification', 'Web updater is disabled. Please use the command line updater or the appropriate update mechanism for your installation method (e.g. Docker pull) to update.') }} | |||
There was a problem hiding this comment.
For some reason, I would prefer "docker pull" over "Docker pull".
However, we have two approvals and a green CI so let's do it ;)
|
Thank you @joshtrichards 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Docker environments the web-updater is not used, but when the
upgrade.disable-webparameter is used to attempt to deter people from using or clicking the updater button, the instructions are still unclear and - worse - misleading.When using this config option, the instructions merely say "use the command line Updater" but that isn't correct in many environments (think downstream Docker image maintainers):
Before: "Please use the command line updater to update. "
After: "Web updater is disabled. Please use the command line updater or the appropriate update mechanism for your installation method (e.g. Docker pull) to update."
P.S. The Download button remaining is also confusing, but that's existing behavior and may be applicable in some scenarios admittedly... so that can be left for a future follow-up.
TODO
Checklist