Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): fix sharing status indicator side after component update #41979

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix(files_sharing): fix sharing status indicator side after component update #41979

merged 1 commit into from
Dec 5, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 2, 2023

Before After
2023-12-02_13-35_1 2023-12-02_13-37

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Dec 2, 2023
@skjnldsv skjnldsv requested a review from a team December 2, 2023 12:38
@skjnldsv skjnldsv self-assigned this Dec 2, 2023
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and emoral435 and removed request for a team December 2, 2023 12:38
@skjnldsv skjnldsv requested review from artonge and szaimen December 2, 2023 12:38
szaimen
szaimen approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but wondering why this is needed

@blizzz blizzz mentioned this pull request Dec 4, 2023
Merged
5 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2023

Fine by me but wondering why this is needed

It is in the commit comments :)

Seems like the components now have max-height/width set too

@skjnldsv
fix(files_sharing): fix sharing status indicator side after component…
09f49a2 
… update

Seems like the components now have max-height/width set too

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2023

/backport to stable28

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2023

files/files_copy-move.cy.ts also failing on master

@skjnldsv skjnldsv merged commit f0108cb into master Dec 5, 2023
38 of 40 checks passed
@skjnldsv skjnldsv deleted the fix/status-size branch December 5, 2023 13:17
@skjnldsv skjnldsv mentioned this pull request Jan 12, 2024
Merged
@skjnldsv
Copy link
Member Author

Backport in #42735

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@nfebe nfebe nfebe approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: sharing regression
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @nfebe @szaimen