docs: add documentation for dns_pinning flag #41981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
susnux
approved these changes
Dec 3, 2023
nickvergessen
approved these changes
Dec 4, 2023
Altahrim
approved these changes
Dec 4, 2023
| * DNS pinning is a security measure against DNS rebinding attacks. | ||
| * | ||
| * We recommend that you leave DNS pinning activated. | ||
| * Only deactivate it if you understand what you are doing. |
There was a problem hiding this comment.
Suggested change
| * Only deactivate it if you understand what you are doing. | |
| * Only deactivate it if your server can't resolve DNS and if you understand what you are doing. |
|
All right, then we leave it undocumented 🫣 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add documentation for dns_pinning flag
TODO
Checklist