Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix: Properly take show_hidden user setting into account for file listing #42023

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[stable28] fix: Properly take show_hidden user setting into account for file listing #42023

merged 3 commits into from
Dec 5, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 5, 2023 •
edited
Loading

  • fix: Properly take show_hidden user setting into account for file listing
  • fix: Also filter out undefined entries from the file list

Combined backport of #42006 and #42021

Summary

TODO

  • ...

Checklist

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Dec 5, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Dec 5, 2023
@juliusknorr juliusknorr changed the title backport/42006/stable28 [stable28] fix: Properly take show_hidden user setting into account for file listing Dec 5, 2023
This was referenced Dec 5, 2023
Merged
Merged
@juliusknorr juliusknorr requested review from AndyScherzinger, ChristophWurst, a team, nfebe, sorbaugh and emoral435 and removed request for a team December 5, 2023 07:40
@AndyScherzinger
Copy link
Member

/compile /

@blizzz blizzz mentioned this pull request Dec 5, 2023
Merged
5 tasks
@juliusknorr
fix: Properly take show_hidden user setting into account for file lis…
6a938e1 
…ting

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Also filter out undefined entries from the file list
52b9028 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/42006/stable28 branch from 971c58f to 52b9028 Compare December 5, 2023 15:58
@juliusknorr
Copy link
Member Author

/compile

@nextcloud-command
chore(assets): Recompile assets
88e9925 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz
Copy link
Member

blizzz commented Dec 5, 2023

new or old ❌ ?

│ ✖ settings/apps.cy.ts 01:39 6 5 1 - - │

@juliusknorr
Copy link
Member Author

"Newer" but unrelated, also fails on the last merged commit https://github.com/nextcloud/server/actions/runs/7104000542/job/19338247398

@juliusknorr juliusknorr merged commit 178ce1f into stable28 Dec 5, 2023
37 of 41 checks passed
@juliusknorr juliusknorr deleted the backport/42006/stable28 branch December 5, 2023 19:50
@landryb landryb mentioned this pull request Mar 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @AndyScherzinger @blizzz @ChristophWurst @nextcloud-command