fix(webdav): multiple headers check #42025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datenangebot
requested review from
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -73,7 +73,8 @@ | |||
| $filesDropPlugin = new \OCA\DAV\Files\Sharing\FilesDropPlugin(); | |||
|
|
|||
| $server = $serverFactory->createServer($baseuri, $requestUri, $authPlugin, function (\Sabre\DAV\Server $server) use ($authBackend, $linkCheckPlugin, $filesDropPlugin) { | |||
| $isAjax = (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] === 'XMLHttpRequest'); | |||
| $request = \OC::$server->getRequest(); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
artonge
approved these changes
Dec 13, 2023
|
Fixed already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some customers had the issue that public shares can't be opened. They result in a reload loop. This is caused by an unauthenticated dav request. I turns out that the
XMLHttpRequestcould be set twice and the logic checks for exact one match.We provided this patch as a quick fix and maybe it's a good idea to bring this to the server to make it more robust besides fixing the main cause.
Customers were on nextcloud 24.0.12.9.
TODO
Checklist