Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Only query the db once for trusted servers #42033

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 5, 2023

Quick finding to save at least one query on every page request, but might be more savings if this method is called from others.

Found as Collabora now calls this twice in different code paths.

@juliusknorr juliusknorr requested review from blizzz, mejo-, a team, ArtificialOwl and icewind1991 and removed request for a team December 5, 2023 11:34
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Dec 5, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🎣

@juliusknorr juliusknorr force-pushed the perf/cache-trusted-servers-per-request branch from 33fdca1 to a0b5551 Compare December 5, 2023 13:58
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the perf/cache-trusted-servers-per-request branch from a0b5551 to 1bff7cc Compare December 5, 2023 15:55
@juliusknorr juliusknorr merged commit 3f6c199 into master Dec 5, 2023
46 of 50 checks passed
@juliusknorr juliusknorr deleted the perf/cache-trusted-servers-per-request branch December 5, 2023 19:52
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants