Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): remove unused userId param of some ocs routes #42036

Closed
wants to merge 1 commit into from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Dec 5, 2023

  • Resolves: #

Summary

We only allow to set the data for the requesting user anyway. AFAIK, this API is not yet used anywhere outside of personal settings.

Proof

public function setOutOfOffice(
string $firstDay,
string $lastDay,
string $status,
string $message,
): DataResponse {

public function clearOutOfOffice(): DataResponse {

Checklist

@st3iny st3iny added this to the Nextcloud 29 milestone Dec 5, 2023
@st3iny st3iny self-assigned this Dec 5, 2023
@st3iny
Copy link
Member Author

st3iny commented Dec 5, 2023

/backport to stable28

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2023
@nickvergessen
Copy link
Member

This was intentional to:

  1. be able to identify calls in access.log more easily
  2. not requiring a new route when implementing admin/group lead support with 👋👤 Allow users to enter out-of-office info, propagate to Calendar, user status, Mail and Talk #40397 (comment)

@nickvergessen
Copy link
Member

nickvergessen commented Dec 5, 2023

AFAIK, this API is not yet used anywhere outside of personal settings.

/me looks at Talk mobile clients
Right, not yet.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/dav/user-id-in-routes branch from 3bd66ac to 4a93cd5 Compare December 5, 2023 15:10
@provokateurin
Copy link
Member

not requiring a new route when implementing admin/group lead support with

This could just be a query parameter, no? Then we don't need an additional endpoint later.

@nickvergessen
Copy link
Member

Conflicting files
dist/dav-settings-personal-availability.js
dist/dav-settings-personal-availability.js.map

If it's not merged before rc3 tonight it will be in 28 final, it's ocs API => 3 years deprecation
So we keep it now?

@blizzz
Copy link
Member

blizzz commented Dec 7, 2023

So we keep it now?

Yes, no stunts five minutes before twelve anymore.

@st3iny st3iny deleted the fix/dav/user-id-in-routes branch December 7, 2023 21:24
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav
Projects
Development

Successfully merging this pull request may close these issues.

6 participants