-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): remove unused userId param of some ocs routes #42036
Conversation
/backport to stable28 |
9f9f01e
to
3bd66ac
Compare
This was intentional to:
|
/me looks at Talk mobile clients |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
3bd66ac
to
4a93cd5
Compare
This could just be a query parameter, no? Then we don't need an additional endpoint later. |
If it's not merged before rc3 tonight it will be in 28 final, it's ocs API => 3 years deprecation |
Yes, no stunts five minutes before twelve anymore. |
Summary
We only allow to set the data for the requesting user anyway. AFAIK, this API is not yet used anywhere outside of personal settings.
Proof
server/apps/dav/lib/Controller/OutOfOfficeController.php
Lines 130 to 135 in 9a206c6
server/apps/dav/lib/Controller/OutOfOfficeController.php
Line 175 in 9a206c6
Checklist