Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppSettingsController.php overwriting currentLanguage #42044

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix AppSettingsController.php overwriting currentLanguage #42044

merged 1 commit into from
Dec 6, 2023

Conversation

1manprojects
Copy link
Contributor

@1manprojects 1manprojects commented Dec 5, 2023 •
edited
Loading

Fix for currentLanguage being overwritten by currentVersion thus breaking App-View

Summary

Fixes Issue where the currentLanguage is being overwritten in certain cases by the currentVersion of the App thus breaking the App View in Nextcloud.

Checklist

@1manprojects
Fix AppSettingsController.php overwriting currentLanguage
6ef5958 
Fix for CurrentLanguage being overwritten by currentVersion thus breaking App-View

Signed-off-by: 1 Man Projects <reed@1manprojects.de>
@1manprojects 1manprojects mentioned this pull request Dec 5, 2023
Closed
8 tasks
@kesselb kesselb added bug 3. to review Waiting for reviews labels Dec 5, 2023
kesselb
kesselb reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this has been sitting in our code for quite a while now ;)

@kesselb kesselb added this to the Nextcloud 29 milestone Dec 5, 2023
nickvergessen
nickvergessen approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5y old bug Oo

@kesselb kesselb requested a review from Altahrim December 5, 2023 22:11
@nickvergessen nickvergessen merged commit 5cf42ff into nextcloud:master Dec 6, 2023
45 of 50 checks passed
@solracsf

This comment was marked as resolved.

Sign in to view
@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen
Copy link
Member

/backport to stable27

@nickvergessen
Copy link
Member

/backport to stable26

@solracsf
Copy link
Member

solracsf commented Dec 6, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 6, 2023
Merged
@solracsf
Copy link
Member

solracsf commented Dec 6, 2023

/backport to stable27

@solracsf solracsf mentioned this pull request Dec 6, 2023
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot obtain the list of apps
5 participants
@1manprojects @solracsf @nickvergessen @juliusknorr @kesselb