Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix look of personal global credentials settings #42058

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 6, 2023

Manual backport of #42031 to stable28

@szaimen szaimen added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Dec 6, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Dec 6, 2023
@szaimen szaimen requested review from jancborchardt, marcoambrosini, a team, nfebe, sorbaugh and emoral435 and removed request for a team December 6, 2023 14:17
@szaimen
Copy link
Contributor Author

szaimen commented Dec 6, 2023

@blizzz may I ignore Block merges during freezes here or does it need to go into 28.0.1?

@szaimen szaimen changed the title fix look of personal global credentials settings [stable28] fix look of personal global credentials settings Dec 6, 2023
@AndyScherzinger AndyScherzinger force-pushed the backport/42031/stable28 branch from e62b71b to 8347675 Compare December 6, 2023 19:35
@AndyScherzinger
Copy link
Member

Given files devs approval reviews I'd say it is fine to merge for RC3, after that it needs to wait for 28.0.1

@AndyScherzinger AndyScherzinger force-pushed the backport/42031/stable28 branch from 8347675 to dc7d18b Compare December 6, 2023 23:03
@szaimen szaimen closed this Dec 7, 2023
@szaimen szaimen reopened this Dec 7, 2023
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger force-pushed the backport/42031/stable28 branch from dc7d18b to 26b9272 Compare December 7, 2023 07:30
@szaimen
Copy link
Contributor Author

szaimen commented Dec 7, 2023

CI failure unrelated

@szaimen szaimen merged commit d9abfa0 into stable28 Dec 7, 2023
57 of 62 checks passed
@szaimen szaimen deleted the backport/42031/stable28 branch December 7, 2023 07:53
@blizzz blizzz mentioned this pull request Dec 7, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants