Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(setupcheck): Add setup check for maintenance_window_start config #42241

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat(setupcheck): Add setup check for maintenance_window_start config #42241

merged 1 commit into from
Dec 18, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 13, 2023 •
edited
Loading

Summary

Missing Configured
grafik grafik

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Dec 13, 2023
@nickvergessen nickvergessen self-assigned this Dec 13, 2023
@nickvergessen nickvergessen force-pushed the feat/noid/setup-check-for-maintenance-window branch 2 times, most recently from 32c71c9 to 367bddd Compare December 13, 2023 15:25
come-nc
come-nc reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick and I agree with @marcelklehr remark, but otherwhise good.
But you will conflict with #41547 #42176 #42177 , wait in line :-P

apps/settings/lib/SetupChecks/MaintenanceWindowStart.php Show resolved Hide resolved
@nickvergessen
feat(setupcheck): Add setup check for maintenance_window_start config
26f4ec6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/noid/setup-check-for-maintenance-window branch from 367bddd to 26f4ec6 Compare December 18, 2023 10:29
@nickvergessen
Copy link
Member Author

But you will conflict with #41547 #42176 #42177 , wait in line :-P

Only on the autoloader, because I'm not changing JS as it is new, right?
So we can merge this?

@nickvergessen
Copy link
Member Author

/backport to stable28

come-nc
come-nc approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum the autoloader and the registration I think, we’ll see.

@nickvergessen nickvergessen merged commit e87cef1 into master Dec 18, 2023
50 checks passed
@nickvergessen nickvergessen deleted the feat/noid/setup-check-for-maintenance-window branch December 18, 2023 14:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 18, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @marcelklehr @come-nc