Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix(files_versions): Check for user and owner before call getUserFolder #42289

Closed
wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

Summary

Backport of #41749

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Dec 14, 2023
@solracsf solracsf added this to the Nextcloud 26.0.11 milestone Dec 14, 2023
IMimeTypeLoader $mimeTypeLoader,
LoggerInterface $logger,
private IRootFolder $rootFolder,
private IVersionManager $versionManager,

Check failure

Code scanning / Psalm

UndefinedClass Error

Class, interface or enum named OCA\Files_Versions\Listener\IVersionManager does not exist
} catch (\Throwable $ex) {
}

$owner = $node->getOwner()?->getUid();

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

OCP\IUser does not contain null
} catch (\Throwable $ex) {
}

$owner = $node->getOwner()?->getUid();

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type OCP\IUser for $__tmp_nullsafe__11348 is never null
@solracsf
Copy link
Member Author

Too much failures, closing on v26.

@solracsf solracsf closed this Dec 15, 2023
@solracsf solracsf deleted the checkUserOwner26 branch December 15, 2023 07:08
@solracsf solracsf removed this from the Nextcloud 26.0.11 milestone Dec 15, 2023
@solracsf solracsf removed the 3. to review Waiting for reviews label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant