chore!: Remove ILogger and its friends
#47978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
nickvergessen,
ChristophWurst,
artonge and
come-nc
come-nc
reviewed
Sep 14, 2024
susnux
force-pushed
the
chore/remove-ilogger
branch
3 times, most recently
from
f76cb32 to
a117646
Compare
susnux
force-pushed
the
chore/remove-ilogger
branch
from
a117646 to
2c5bea4
Compare
come-nc
reviewed
Sep 15, 2024
susnux
force-pushed
the
chore/remove-ilogger
branch
from
47eb808 to
d24ffc8
Compare
skjnldsv
approved these changes
Sep 16, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ated stuff Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/remove-ilogger
branch
from
d24ffc8 to
5cce140
Compare
come-nc
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes all public parts of the
ILoggerlogging functions which were deprecated for quite some time.What is kept are the log levels which are un-deprecated, because even if we now support PSR Log levels we need this for working with our log file handling.
Checklist