Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(a11y): Add OTF font loading check #48073

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 16, 2024

Backport of PR #48063

Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv skjnldsv enabled auto-merge September 16, 2024 09:36
@skjnldsv skjnldsv merged commit 0714e14 into stable30 Sep 16, 2024
172 checks passed
@skjnldsv skjnldsv deleted the backport/48063/stable30 branch September 16, 2024 11:00
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
4 tasks
@joho1968
Copy link

For 29.0.8, this persistently generates the following error messge:

Could not check for otf loading support. Please check manually if your webserver serves .otf files. To allow this check to run you have to make sure that your webserver can connect to itself. Therefor it must be able to resolve and connect to at least one its trusted_domains or the overwrite.cli.url.

The link to the documentation in question points to https://docs.nextcloud.com/server/29/admin_manual/installation/nginx.html

Searching for .otf or otf gives no matches.

This error was not present in 29.0.7.

@nickvergessen
Copy link
Member

This error was not present in 29.0.7.

Yeah it's newly added there. Seems like no one updated the nginx documentation yet.

@nickvergessen
Copy link
Member

change is in nextcloud/documentation#12273

@joho1968
Copy link

This error was not present in 29.0.7.

Yeah it's newly added there. Seems like no one updated the nginx documentation yet.

Thanks.

I'm not complaining here, but it feels "somewhat" odd that a configuration change would be required for a "minor" upgrade from 29.0.7 to 29.0.8. I would expect that minor bump to mean fixes only.

Just my two cents.

@nickvergessen
Copy link
Member

I would expect that minor bump to mean fixes only.

Yeah we ship otf fonts since quite some time, but only now it was noticed that some servers don't serve it correctly. It went unnoticed a long time as other fonts whip woff+otf and then the fall back to otf never happened.

@z3ntu
Copy link

z3ntu commented Nov 5, 2024

Worth noting that on my Apache-based setup I needed to run occ maintenance:update:htaccess to "regenerate" the .htaccess file to make otf loading work. This is probably related to me using 'htaccess.RewriteBase' => '/', but the htaccess never got updated to include otf by any regular maintenance step.

@nickvergessen
Copy link
Member

Hmm that's kind of surprising. I would have thought the updater does it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants