-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable30] fix(a11y): Add OTF font loading check #48073
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
For 29.0.8, this persistently generates the following error messge:
The link to the documentation in question points to https://docs.nextcloud.com/server/29/admin_manual/installation/nginx.html Searching for This error was not present in 29.0.7. |
Yeah it's newly added there. Seems like no one updated the nginx documentation yet. |
change is in nextcloud/documentation#12273 |
Thanks. I'm not complaining here, but it feels "somewhat" odd that a configuration change would be required for a "minor" upgrade from 29.0.7 to 29.0.8. I would expect that minor bump to mean fixes only. Just my two cents. |
Yeah we ship otf fonts since quite some time, but only now it was noticed that some servers don't serve it correctly. It went unnoticed a long time as other fonts whip woff+otf and then the fall back to otf never happened. |
Worth noting that on my Apache-based setup I needed to run |
Hmm that's kind of surprising. I would have thought the updater does it automatically. |
Backport of PR #48063