Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mail provider settings #48134

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: mail provider settings #48134

merged 1 commit into from
Nov 13, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski marked this pull request as draft September 17, 2024 11:48
@SebastianKrupinski SebastianKrupinski self-assigned this Sep 17, 2024
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Sep 17, 2024
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review September 17, 2024 13:28
@SebastianKrupinski
Copy link
Contributor Author

image

New setting in administration section

@SebastianKrupinski
Copy link
Contributor Author

@marcoambrosini

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.sample.php needs an update

apps/settings/lib/Listener/MailSettingsEventListener.php Outdated Show resolved Hide resolved
apps/settings/lib/Listener/MailSettingsEventListener.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated Show resolved Hide resolved
return;
}

if ($event instanceof DeclarativeSettingsSetValueEvent) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType

Docblock-defined type OCP\Settings\Events\DeclarativeSettingsSetValueEvent for $event is always OCP\Settings\Events\DeclarativeSettingsSetValueEvent
@SebastianKrupinski
Copy link
Contributor Author

image

Latest version

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ from design

apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Outdated Show resolved Hide resolved
apps/settings/lib/Settings/Admin/SystemMail.php Outdated Show resolved Hide resolved
apps/settings/lib/Settings/Admin/SystemMail.php Outdated Show resolved Hide resolved
apps/settings/lib/Settings/Admin/SystemMail.php Outdated Show resolved Hide resolved
apps/settings/lib/Listener/SystemMailSettingsListener.php Outdated Show resolved Hide resolved
apps/settings/lib/Listener/SystemMailSettingsListener.php Outdated Show resolved Hide resolved
apps/settings/lib/Listener/SystemMailSettingsListener.php Outdated Show resolved Hide resolved
@kesselb
Copy link
Contributor

kesselb commented Sep 24, 2024

The Linter is failing.

@kesselb kesselb dismissed their stale review September 25, 2024 09:09

config.sample.php update no longer required

@SebastianKrupinski SebastianKrupinski force-pushed the feat/mail-provider-settings branch from da9179b to 293cc53 Compare October 7, 2024 00:01
@SebastianKrupinski SebastianKrupinski force-pushed the feat/mail-provider-settings branch from 293cc53 to f922723 Compare October 21, 2024 12:47
@SebastianKrupinski SebastianKrupinski force-pushed the feat/mail-provider-settings branch 3 times, most recently from daa219f to 951d914 Compare November 12, 2024 17:47
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/mail-provider-settings branch from d716da5 to 3e87069 Compare November 12, 2024 18:20
@kesselb kesselb merged commit 22e2419 into master Nov 13, 2024
186 checks passed
@kesselb kesselb deleted the feat/mail-provider-settings branch November 13, 2024 13:31
@kesselb
Copy link
Contributor

kesselb commented Nov 13, 2024

/backport to stable30

@SebastianKrupinski
Copy link
Contributor Author

@kesselb Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

6 participants