refactor(updatenotification): Migrate legacy code #48323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
provokateurin
approved these changes
Sep 24, 2024
Pytal
approved these changes
Sep 24, 2024
1. Remove hook usage and just provide an initial state 2. Replace jQuery code with modern non-deprecated frontend code Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/legacy-updatenotification
branch
from
eefe56a to
71f1e0c
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
come-nc
reviewed
Sep 26, 2024
| @@ -0,0 +1,24 @@ | |||
| /** | |||
There was a problem hiding this comment.
Why is the file still named with -legacy?
There was a problem hiding this comment.
Legacy did not meant the content but the usage: It is only needed if you do not have notifications app enabled.
We could also name it -fallback
There was a problem hiding this comment.
fallback would be clearer for me, but no big deal, was just my curiosity when reading this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also fixed the appinfo.xml as the order of entries is fixed in the XSD.
Screen shots
Checklist