Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Print RTL limited characters in translation-checker #48839

Merged
merged 2 commits into from
Oct 23, 2024
Merged

build: Print RTL limited characters in translation-checker #48839

merged 2 commits into from
Oct 23, 2024

Conversation

provokateurin
Copy link
Member

Summary

So we know which characters are causing problems.

Checklist

@provokateurin
build: Print RTL limited characters in translation-checker
f660e4c 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added the 3. to review Waiting for reviews label Oct 22, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 22, 2024
@susnux susnux requested a review from nickvergessen October 22, 2024 11:05
@nickvergessen
Copy link
Member

Counter proposal:

$ php build/translation-checker.php 
ERROR: There were 1 errors:

…/apps/files/l10n/vi.json
  Contains a RTL limited characters in the translations. Offending strings:
    "Fill template fields" : "‎Thiết lập thư mục mẫu‎",

@nickvergessen
build: Show the actual string
61e3fa0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@provokateurin
Copy link
Member Author

Makes sense 👍

@nickvergessen nickvergessen requested a review from susnux October 23, 2024 07:42
@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen
Copy link
Member

/backport to stable29

@nickvergessen
Copy link
Member

/backport to stable30

@susnux susnux merged commit 2055516 into master Oct 23, 2024
175 checks passed
@susnux susnux deleted the build/translation-checker-print-rtl-limited-characters branch October 23, 2024 11:42
This was referenced Oct 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @nickvergessen @susnux