Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix file names alignment in Files List in UI RTL mode. #48909

Closed
wants to merge 0 commits into from

Conversation

falghamdi125
Copy link
Contributor

Summary

This PR fixes the alignment of file names in RTL mode.

Before:
image

After:
image
The PR doesn't break non-RTL UI (English below)
image

Checklist

@skjnldsv skjnldsv requested review from a team, susnux, artonge and nfebe and removed request for a team October 29, 2024 16:04
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Oct 29, 2024
@skjnldsv
Copy link
Member

/compile

@skjnldsv
Copy link
Member

@falghamdi125 can you compile with npm run build please?
I cannot push here as you used master as branch name I think

@falghamdi125
Copy link
Contributor Author

Files assets have been compiled!

@falghamdi125 falghamdi125 changed the title fix(files): Fix file names alignment in Files List in UI RTL mode fix(files): Fix file names alignment in Files List in UI RTL mode. Oct 30, 2024
@falghamdi125
Copy link
Contributor Author

You may reopen the PR and update source to this branch:
https://github.com/falghamdi125/server/commits/fix-files-names-align-in-rtl

@susnux
Copy link
Contributor

susnux commented Oct 30, 2024

@falghamdi125 could you please open a PR from that branch?

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File names incorrect alignment in UI RTL mode.
3 participants