Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow WebP content type in PhotoCache #48943

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 28, 2024

Summary

I recreated the PR in the repository to get green CI. I also tested it locally and it works fine.

It seems like CardDAV's PhotoCache is currently only supporting PNG, JPEG, GIF and ICO images.

Nextcloud intercepts GET requests on addressbook URLs ending with ?photo, and uses ALLOWED_CONTENT_TYPES to set the type name, returning 404 if the content type is not supported (not part of the allowed content types struct).

Checklist

Signed-off-by: Miguel Sánchez de León Peque <peque@ieco.io>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added enhancement 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Oct 28, 2024
@st3iny st3iny added this to the Nextcloud 31 milestone Oct 28, 2024
@st3iny st3iny requested a review from tcitworld October 28, 2024 12:45
@st3iny st3iny self-assigned this Oct 28, 2024
@st3iny st3iny enabled auto-merge October 28, 2024 13:01
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 28, 2024
@st3iny st3iny merged commit 2a437b4 into master Oct 28, 2024
177 checks passed
@st3iny st3iny deleted the feat/photo-cache-webp branch October 28, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: carddav Related to CardDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image not shown when using WebP instead of JPEG
4 participants