Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Password field must not be required if already set #48991

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(files_sharing): Password field must not be required if already set #48991

merged 2 commits into from
Oct 30, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 29, 2024 •
edited
Loading

If there is already a password, there is no need to require the password in the setting ('newPassword'). It is only required for new shares.

Checklist

@susnux susnux requested review from artonge, nfebe and Pytal October 29, 2024 22:59
@susnux
Copy link
Contributor Author

susnux commented Oct 29, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Oct 29, 2024

/backport to stable29

@susnux susnux added this to the Nextcloud 31 milestone Oct 29, 2024
@susnux susnux force-pushed the fix/password-field-sharing branch from 2c8b26f to f984570 Compare October 30, 2024 09:15
susnux added 2 commits October 30, 2024 10:30
@susnux
fix(files_sharing): Password field must not be required if already set
abcb02f 
If there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
e13b6d3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/password-field-sharing branch from f984570 to e13b6d3 Compare October 30, 2024 09:31
nfebe
nfebe approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Wondering what would happen if someone attempts to remove password on an existing share, if possible.

@susnux
Copy link
Contributor Author

susnux commented Oct 30, 2024

Wondering what would happen if someone attempts to remove password on an existing share, if possible.

If the password is enforced, then this is not possible, you can only modify it.
If it is optional then you can simply remove the checkmark for "password protected" to remove the password

@susnux susnux merged commit 878ccc4 into master Oct 30, 2024
118 checks passed
@susnux susnux deleted the fix/password-field-sharing branch October 30, 2024 12:40
This was referenced Oct 30, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe nfebe approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Sharing via email errors with missing password
3 participants
@susnux @nfebe @provokateurin