[stable30] fix(apps-store): Fix exception on generating preview url for installed app screenshot #49044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
…enshots Some installed apps meant for older server versions might unexpectedly offer up screenshot values in a non-string format (e.g. health). Avoid an exception by checking first if the first app screenshot is indeed a string and otherwise we take the value of the parameter Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…rays Signed-off-by: Joas Schilling <coding@schilljs.com>
backportbot
bot
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $appScreenshot = $appScreenshot['@value']; | ||
| } | ||
|
|
||
| $app['screenshot'] = $this->createProxyPreviewUrl($appScreenshot); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
8 tasks
8 tasks
joshtrichards
approved these changes
Nov 1, 2024
|
This should be merged before 30.0.2 final to avoid #49042 |
susnux
approved these changes
Nov 1, 2024
joshtrichards
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #48912