-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Improvements on sharing details #49351
Conversation
815f1eb
to
d951399
Compare
ShareType
across file_sharingaef75b5
to
e641b8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor is bigger than I thought it would be. :)
6af29f9
to
386eac0
Compare
386eac0
to
c526982
Compare
c526982
to
3094a2f
Compare
3094a2f
to
6ba172b
Compare
/backport to 30 |
/backport to 29 |
6ba172b
to
e86acd6
Compare
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
e86acd6
to
2034c3e
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The backport to # Switch to the target branch and update it
git checkout 29
git pull origin 29
# Create the new backport branch
git checkout -b backport/49351/29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d6efc531 2034c3e1 19b05511
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49351/29 Error: Failed to clone repository: Failed to checkout branches: fatal: ambiguous argument 'origin/29': unknown revision or path not in the working tree. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout 30
git pull origin 30
# Create the new backport branch
git checkout -b backport/49351/30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d6efc531 2034c3e1 19b05511
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49351/30 Error: Failed to clone repository: Failed to checkout branches: fatal: ambiguous argument 'origin/30': unknown revision or path not in the working tree. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable30 |
/backport to stable29 |
fix: Only show share permission if re-sharable
refactor: Use new ShareType across file_sharing