Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Improvements on sharing details #49351

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 18, 2024

@nfebe nfebe added 3. to review Waiting for reviews feature: sharing labels Nov 18, 2024
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 815f1eb to d951399 Compare November 18, 2024 16:51
@nfebe nfebe changed the title refactor: Use new ShareType across file_sharing enh: Improvements on sharing details Nov 18, 2024
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch 3 times, most recently from aef75b5 to e641b8c Compare November 18, 2024 17:14
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor is bigger than I thought it would be. :)

@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch 2 times, most recently from 6af29f9 to 386eac0 Compare November 18, 2024 18:03
@nfebe nfebe marked this pull request as draft November 18, 2024 18:24
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 386eac0 to c526982 Compare November 18, 2024 19:17
@nfebe nfebe marked this pull request as ready for review November 18, 2024 19:18
@nfebe nfebe requested review from artonge and Pytal November 19, 2024 14:55
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from c526982 to 3094a2f Compare November 25, 2024 18:04
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 3094a2f to 6ba172b Compare December 3, 2024 10:03
@nfebe
Copy link
Contributor Author

nfebe commented Dec 3, 2024

/backport to 30

@nfebe
Copy link
Contributor Author

nfebe commented Dec 3, 2024

/backport to 29

@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 6ba172b to e86acd6 Compare December 3, 2024 10:29
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from e86acd6 to 2034c3e Compare December 3, 2024 13:25
@nfebe nfebe requested a review from artonge December 3, 2024 13:25
@nfebe
Copy link
Contributor Author

nfebe commented Dec 3, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit 5ee4c9e into master Dec 3, 2024
119 of 120 checks passed
@nfebe nfebe deleted the fix/no-issue/no-reshare-perms-4-email-shares branch December 3, 2024 14:16
Copy link

backportbot bot commented Dec 3, 2024

The backport to 29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 29
git pull origin 29

# Create the new backport branch
git checkout -b backport/49351/29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d6efc531 2034c3e1 19b05511

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49351/29

Error: Failed to clone repository: Failed to checkout branches: fatal: ambiguous argument 'origin/29': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Dec 3, 2024

The backport to 30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 30
git pull origin 30

# Create the new backport branch
git checkout -b backport/49351/30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d6efc531 2034c3e1 19b05511

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49351/30

Error: Failed to clone repository: Failed to checkout branches: fatal: ambiguous argument 'origin/30': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@solracsf
Copy link
Member

solracsf commented Dec 3, 2024

/backport to stable30

@solracsf
Copy link
Member

solracsf commented Dec 3, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants