-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contacts-menu): implement custom javascript hook action #49375
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to register this in the backend?
One the one side we already have link actions, but on the other link actions make sense for php-only apps and javascript actions would always need JS code.
Asking because all other APIs we introduced lately for similar things are purely frontend. E.g. file actions, views, filters.
Also older API is frontend only (e.g. user list rows, user actions etc).
a40d301
to
a579d7c
Compare
Hmm, that is actually a good point. But since I'm extending an existing API here, I'd prefer to keep it in the backend for now. Otherwise, it might get confusing as the avatar menu is populated from multiple sources of truth. I'll think about it again. |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
a579d7c
to
b48320c
Compare
Ferdinand is right. The OCP API doesn't make sense. The menu has to registered from the frontend only, via |
:key="idx" | ||
:key="`${idx}-link`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but my LSP complained that it is illegal to have the same key on the on both nodes of v-if
/v-else
.
Summary
Adds a new frontend-only contacts menu action registered via
registerContactsMenuAction("foo-bar")
from@nextcloud/vue
.Note: Please focus on the contact menu changes when reviewing this PR. The modal you see might change and is part of the Calendar app.
2024-11-27.14-35-29.mp4
Checklist
Backports requested where applicable (ex: critical bugfixes)