Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): Resolve race condition blocking link share requests #49442

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 22, 2024

Fixed a race condition in the frontend that prevented share link creation requests from being sent to the backend. Instead of communicating with the server, the share links were incorrectly added to the frontend list, and a new menu to create another link appeared.

This fix ensures the correct sequence of actions, allowing share links to be properly created and synchronized with the backend.

Checklist

  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Backports requested where applicable (ex: critical bugfixes)

Fixed a race condition in the frontend that prevented share link creation requests
from being sent to the backend. Instead of communicating with the server,
the share links were incorrectly added to the frontend list, and a new menu
to create another link appeared.

This fix ensures the correct sequence of actions, allowing share links to be
properly created and synchronized with the backend.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from a73510b to ea48600 Compare December 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant