Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): make second click as confirmation on templates picker #49568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luka-nextcloud
Copy link
Contributor

Summary

Accept the second click as create confirmation.

Video

demo.webm

Checklist

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud requested review from elzody and juliusknorr and removed request for skjnldsv November 29, 2024 15:58
@luka-nextcloud luka-nextcloud added the 3. to review Waiting for reviews label Nov 29, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and the code changes are pretty straightforward. Most of the tests for the template picker are actually in the richdocuments repository, but maybe it would also be beneficial to have a small test in there for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Template picker UX improvements
2 participants