chore(bruteforce): allows to configure max attempts before request abort #49599
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
added
2. developing
Altahrim
requested review from
nickvergessen,
a team,
icewind1991,
skjnldsv and
come-nc
and removed request for
a team
Altahrim
added
3. to review
nickvergessen
approved these changes
Dec 2, 2024
come-nc
reviewed
Dec 2, 2024
| * | ||
| * When more than max-attempts login requests are sent to Nextcloud, requests | ||
| * will abort with "429 Too Many Requests". | ||
| * For security reasons, changfe it only if you know what you are doing. |
There was a problem hiding this comment.
Suggested change
| * For security reasons, changfe it only if you know what you are doing. | |
| * For security reasons, change it only if you know what you are doing. |
solracsf
reviewed
Dec 2, 2024
| @@ -431,6 +431,17 @@ | |||
| */ | |||
| 'auth.bruteforce.protection.testing' => false, | |||
|
|
|||
| /** | |||
| * Brute force protection maximum number of attempts before blocking | |||
There was a problem hiding this comment.
Suggested change
| * Brute force protection maximum number of attempts before blocking | |
| * Brute force protection: maximum number of attempts before blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows to configure the number of failed attempts before blocking login requests
Checklist