Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: Add command to update re-share if shared-by user has been revoked #49613

Open
wants to merge 1 commit into
base: stable29
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 3, 2024

Backport of #43025

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Dec 3, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.10 milestone Dec 3, 2024
@luka-nextcloud luka-nextcloud force-pushed the backport/43025/stable29 branch from fe97427 to 07e62ab Compare December 6, 2024 19:04
@luka-nextcloud luka-nextcloud marked this pull request as ready for review December 6, 2024 19:09
…erring

Signed-off-by: Luka Trovic <luka@nextcloud.com>

class FixShareOwners extends Base {
public function __construct(
private readonly OrphanHelper $orphanHelper,

Check failure

Code scanning / Psalm

InvalidDocblock Error

Param1 of OCA\Files_Sharing\Command\FixShareOwners::__construct has invalid syntax

class FixShareOwners extends Base {
public function __construct(
private readonly OrphanHelper $orphanHelper,

Check failure

Code scanning / Psalm

ParseError Error

Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 19
}

public function execute(InputInterface $input, OutputInterface $output): int {
$shares = $this->orphanHelper->getAllShares();

Check failure

Code scanning / Psalm

UndefinedThisPropertyFetch Error

Instance property OCA\Files_Sharing\Command\FixShareOwners::$orphanHelper is not defined
@skjnldsv
Copy link
Member

Psalm issues to fix

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants