Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: make taskprocessing task types toggleable #49727

Merged
merged 16 commits into from
Dec 18, 2024

Conversation

janepie
Copy link
Member

@janepie janepie commented Dec 9, 2024

Summary

Makes taskprocessing task types toggable in AI admin settings: disabled types will not be available and will not show up in e.g. the assistant.
Task types are enabled by default. The values are stored in a new appconfig db record.

Before:
Screenshot_20241209_112014

After:
Screenshot_20241209_095400

Checklist

@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch from 6e42792 to adf5524 Compare December 9, 2024 08:19
@janepie janepie changed the title Feat/make tasks types toggleable Feat: make taskprocessing task types toggleable Dec 9, 2024
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch 3 times, most recently from 51ae6eb to b4437fb Compare December 9, 2024 10:14
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch 15 times, most recently from 7312acd to 1109a5e Compare December 11, 2024 17:05
@janepie janepie marked this pull request as ready for review December 11, 2024 17:05
@janepie janepie requested a review from skjnldsv as a code owner December 11, 2024 17:05
@janepie janepie requested a review from julien-nc December 11, 2024 17:06
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch from 1109a5e to 28ff78b Compare December 11, 2024 17:13
@janepie janepie removed the request for review from skjnldsv December 11, 2024 17:13
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch from 8f56d71 to 0a22e93 Compare December 11, 2024 17:19
@janepie janepie requested a review from marcelklehr December 11, 2024 17:20
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch from 0a22e93 to 25f74fe Compare December 12, 2024 09:10
@janepie janepie requested a review from kyteinsky December 12, 2024 09:13
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎉 Congrats on your first server PR :)

@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch 3 times, most recently from dfb2519 to d31eb38 Compare December 18, 2024 11:52
@janepie
Copy link
Member Author

janepie commented Dec 18, 2024

@AndyScherzinger can you force merge? I am pretty sure the Cypress runner failing is not my fault as it's failing for all PRs right now 😅

janepie and others added 16 commits December 18, 2024 18:32
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie janepie force-pushed the feat/make-tasks-types-toggleable branch from d31eb38 to 75e64e2 Compare December 18, 2024 17:32
@AndyScherzinger AndyScherzinger merged commit a60f71b into master Dec 18, 2024
187 of 189 checks passed
Copy link

welcome bot commented Dec 18, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger AndyScherzinger deleted the feat/make-tasks-types-toggleable branch December 18, 2024 19:08
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle task types in admin settings
5 participants