Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files_sharing): Correct property enforced property names #49808

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 11, 2024

Backport of #49799

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from skjnldsv, sorbaugh and nfebe December 11, 2024 20:47
@backportbot backportbot bot added the 3. to review Waiting for reviews label Dec 11, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.11 milestone Dec 11, 2024
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the backport/49799/stable29 branch from c39d830 to 996fd0d Compare December 11, 2024 20:52
@nfebe nfebe marked this pull request as ready for review December 11, 2024 20:52
@nfebe
Copy link
Contributor

nfebe commented Dec 11, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

Possible performance regression detected

Show Output
7 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 7 queries added
  - UPDATE "oc_filecache" SET "size" = :dcValue3 WHERE ("fileid" = :dcValue1) AND (("size" <> :dcValue2) OR ("size" IS NULL))
  - UPDATE "oc_filecache" SET "size" = :dcValue3 WHERE ("fileid" = :dcValue1) AND (("size" <> :dcValue2) OR ("size" IS NULL))
  - SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
  - SELECT "path" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("fileid" = :dcValue2)
  + SELECT "storage", "path", "mimetype" FROM "oc_filecache" WHERE "fileid" = :dcValue1
  + SELECT "storage_id", "root_id", "user_id", "mount_point", "mount_id", "f"."path", "mount_provider_class" FROM "oc_mounts" "m" INNER JOIN "oc_filecache" "f" ON "m"."root_id" = "f"."fileid" WHERE ("storage_id" = ?) AND ("user_id" = ?)
  + SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE "filecache"."fileid" = :dcValue1
  + DELETE FROM "oc_filecache" WHERE "fileid" = :dcValue1
  + DELETE FROM "oc_filecache_extended" WHERE "fileid" = :dcValue1
  + DELETE FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
  + DELETE FROM "oc_files_metadata_index" WHERE "file_id" = :dcValue1
  + SELECT "json", "sync_token" FROM "oc_files_metadata" WHERE "file_id" = :dcValue1
  + SELECT "fileid" FROM "oc_filecache" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)
  + UPDATE "oc_file_locks" SET "lock" = :dcValue1, "ttl" = :dcValue2 WHERE ("key" = :dcValue3) AND ("lock" = :dcValue4)
  + SELECT "filecache"."fileid", "storage", "path", "path_hash", "filecache"."parent", "filecache"."name", "mimetype", "mimepart", "size", "mtime", "storage_mtime", "encrypted", "etag", "filecache"."permissions", "checksum", "unencrypted_size", "metadata_etag", "creation_time", "upload_time", "meta"."json" AS "meta_json", "meta"."sync_token" AS "meta_sync_token" FROM "oc_filecache" "filecache" LEFT JOIN "oc_filecache_extended" "fe" ON "filecache"."fileid" = "fe"."fileid" LEFT JOIN "oc_files_metadata" "meta" ON "filecache"."fileid" = "meta"."file_id" WHERE ("storage" = :dcValue1) AND ("path_hash" = :dcValue2)

@skjnldsv skjnldsv merged commit 907b44a into stable29 Dec 11, 2024
112 of 113 checks passed
@skjnldsv skjnldsv deleted the backport/49799/stable29 branch December 11, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants