fix(federation): Fix parsing system messages for federated users #18257
Annotations
3 errors
Run coding standards check:
lib/Federation/Proxy/TalkV1/UserConverter.php#L103
lib/Federation/Proxy/TalkV1/UserConverter.php:103:13: InvalidReturnType: The declared return type 'array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}' for OCA\Talk\Federation\Proxy\TalkV1\UserConverter::convertMessage is incorrect, got 'array{parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}|mixed, token: string, ...<array-key, mixed>}' (see https://psalm.dev/011)
|
Run coding standards check:
lib/Federation/Proxy/TalkV1/UserConverter.php#L114
lib/Federation/Proxy/TalkV1/UserConverter.php:114:10: InvalidReturnStatement: The inferred type 'array{parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}|mixed, token: string, ...<array-key, mixed>}' does not match the declared return type 'array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, parent?: array{actorDisplayName: string, actorId: string, actorType: string, deleted?: true, expirationTimestamp: int, id: int, isReplyable: bool, lastEditActorDisplayName?: string, lastEditActorId?: string, lastEditActorType?: string, lastEditTimestamp?: int, markdown: bool, message: string, messageParameters: array<string, array<string, mixed>>, messageType: string, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}, reactions: array<string, int>|stdClass, referenceId: string, silent?: bool, systemMessage: string, timestamp: int, token: string}' for OCA\Talk\Federation\Proxy\TalkV1\UserConverter::convertMessage (see https://psalm.dev/128)
|
Run coding standards check
Process completed with exit code 2.
|
Loading