Skip to content

Commit

Permalink
fix(guests): Don't force remove guests but leave it to the "purge logic"
Browse files Browse the repository at this point in the history
Currently guests with a display name are not cleaned up, to keep
their name for chat messages and other activity.

Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
nickvergessen authored and backportbot[bot] committed Dec 11, 2024
1 parent c669ad5 commit d024769
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions lib/Controller/SignalingController.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

use GuzzleHttp\Exception\ConnectException;
use OCA\Talk\Config;
use OCA\Talk\Events\AAttendeeRemovedEvent;
use OCA\Talk\Events\BeforeSignalingResponseSentEvent;
use OCA\Talk\Exceptions\ParticipantNotFoundException;
use OCA\Talk\Exceptions\RoomNotFoundException;
Expand Down Expand Up @@ -859,15 +858,7 @@ private function backendRoom(array $roomRequest): DataResponse {
$this->sessionService->updateLastPing($participant->getSession(), $this->timeFactory->getTime());
}
} elseif ($action === 'leave') {
// Guests are removed completely as they don't reuse attendees,
// but this is only true for guests that joined directly.
// Emails are retained as their PIN needs to remain and stay
// valid.
if ($participant->getAttendee()->getActorType() === Attendee::ACTOR_GUESTS) {
$this->participantService->removeAttendee($room, $participant, AAttendeeRemovedEvent::REASON_LEFT);
} else {
$this->participantService->leaveRoomAsSession($room, $participant);
}
$this->participantService->leaveRoomAsSession($room, $participant);
}

$this->logger->debug('Room request to "{action}" room {token} by actor {actorType}/{actorId}', [
Expand Down

0 comments on commit d024769

Please sign in to comment.