fix(participantStore): update the whole participant object

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
nextcloud · Jan 25, 2024 · e8dbc00 · e8dbc00
1 parent 931617e
commit e8dbc00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/store/participantsStore.js b/src/store/participantsStore.js
@@ -317,7 +317,7 @@ const mutations = {
 
 	updateParticipant(state, { token, attendeeId, updatedData }) {
 		if (state.attendees[token] && state.attendees[token][attendeeId]) {
-			state.attendees[token][attendeeId] = Object.assign(state.attendees[token][attendeeId], updatedData)
+			state.attendees[token][attendeeId] = Object.assign({}, state.attendees[token][attendeeId], updatedData)
 		} else {
 			console.error('Error while updating the participant')
 		}

diff --git a/src/store/participantsStore.spec.js b/src/store/participantsStore.spec.js
@@ -617,6 +617,7 @@ describe('participantsStore', () => {
 	})
 
 	describe('joining conversation', () => {
+		let getTokenMock
 		let getParticipantIdentifierMock
 		let participantData
 		let joinedConversationEventMock
@@ -625,6 +626,7 @@ describe('participantsStore', () => {
 			joinedConversationEventMock = jest.fn()
 			EventBus.$once('joined-conversation', joinedConversationEventMock)
 
+			getTokenMock = jest.fn().mockReturnValue(TOKEN)
 			getParticipantIdentifierMock = jest.fn().mockReturnValue({
 				attendeeId: 1,
 			})
@@ -636,6 +638,7 @@ describe('participantsStore', () => {
 				inCall: PARTICIPANT.CALL_FLAG.DISCONNECTED,
 			}
 
+			testStoreConfig.getters.getToken = () => getTokenMock
 			testStoreConfig.getters.getParticipantIdentifier = () => getParticipantIdentifierMock
 			testStoreConfig.actions.setCurrentParticipant = jest.fn()
 			testStoreConfig.actions.addConversation = jest.fn().mockImplementation((context) => {
@@ -683,8 +686,8 @@ describe('participantsStore', () => {
 
 			expect(joinConversation).toHaveBeenCalledWith({ token: TOKEN, forceJoin: true })
 
-			expect(testStoreConfig.actions.setCurrentParticipant).toHaveBeenCalledWith(expect.anything(), participantData)
-			expect(testStoreConfig.actions.addConversation).toHaveBeenCalledWith(expect.anything(), participantData)
+			expect(testStoreConfig.actions.setCurrentParticipant).toHaveBeenCalledWith(expect.anything(), updatedParticipantData)
+			expect(testStoreConfig.actions.addConversation).toHaveBeenCalledWith(expect.anything(), updatedParticipantData)
 
 			expect(getParticipantIdentifierMock).toHaveBeenCalled()