Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow-up(Forwarder) - minor enhancements: #10630

Closed
Antreesy opened this issue Oct 4, 2023 · 0 comments · Fixed by #10638
Closed

follow-up(Forwarder) - minor enhancements: #10630

Antreesy opened this issue Oct 4, 2023 · 0 comments · Fixed by #10638
Assignees
@DorraJaouad
Labels
1. to develop feature: frontend 🖌️ "Web UI" client technical debt
Milestone
💔 Backlog

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Oct 4, 2023

follow-up from #10603:

  • rename component to MessageForwarder
  • fix <div class="forwarder"> style, as it's breaking MessageButtonBar appearance
  • get rid of doubled usage of NcEmptyContent (was added here: 45cb031)
  • check how openConversation method closes modal
  • rework code, rename and cleanup methods and computed props
  • make backportable changes

See screenshot attached:
image

Originally posted by @Antreesy in #10603 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DorraJaouad DorraJaouad

Labels
1. to develop feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
💔 Backlog
Development

Successfully merging a pull request may close this issue.

Fix(MessageForwarder + NewGroupConversation) - The confirmation page enhancement nextcloud/spreed
2 participants
@DorraJaouad @Antreesy