Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(MessageForwarder + NewGroupConversation) - The confirmation page enhancement #10638

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Fix(MessageForwarder + NewGroupConversation) - The confirmation page enhancement #10638

merged 3 commits into from
Oct 9, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 5, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🚧 Tasks

  • Component renaming ( MessageForwarder)
  • Fixing the UI ( NcEmptyContent duplication and the buttons bar )
  • Replacing the new conversation page confirmation with NcEmptyContent
  • Show loading status before the confirmation page.

To do:

  • Visual review
  • Code review

🏁 Checklist

@DorraJaouad
Rename to MessageForwarder and remove the empty content duplication. …
f402e2d 
…+ Some minor fix

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💙 Next Major (28) milestone Oct 5, 2023
@DorraJaouad DorraJaouad requested a review from Antreesy October 5, 2023 13:40
@DorraJaouad DorraJaouad self-assigned this Oct 5, 2023
@DorraJaouad DorraJaouad changed the title Fix/10630/message forwarder improvement Fix(MessageForwarder + NewGroupConversation) - The confirmation page enhancement Oct 5, 2023
@DorraJaouad
Improve the NewGroupConversation confirmation
8aea99d 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/10630/message-forwarder-improvement branch from 3a79c27 to 8aea99d Compare October 5, 2023 16:29
Antreesy
Antreesy reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for improvement

src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageForwarder.vue Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageForwarder.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks for handling!

@DorraJaouad DorraJaouad enabled auto-merge October 6, 2023 11:23
@DorraJaouad
Style fixes and conditions adjusting
6e20663 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/10630/message-forwarder-improvement branch from 7d6bb30 to 6e20663 Compare October 9, 2023 21:23
@DorraJaouad DorraJaouad merged commit b1fbac7 into master Oct 9, 2023
26 checks passed
@DorraJaouad DorraJaouad deleted the fix/10630/message-forwarder-improvement branch October 9, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

follow-up(Forwarder) - minor enhancements:
3 participants
@DorraJaouad @nickvergessen @Antreesy