RFC: Mentions in forwarded messages

[Antreesy]

ATM we handle mentions by names here:

spreed/src/store/messagesStore.js

Line 1266 in 77a4405

async forwardMessage(context, { messageToBeForwarded }) {

Depending on correlation id/name it will be rendered in different conversation if:

• name === id
• name.split(' ').includes(id).

Notification won't be triggered for this person though (or something prevents reproducing it)
When developing, all mention options should be considered:

@all
@user1
@"user@2"
@"user 3"

See screenshot attached

Originally posted by @Antreesy in #10603 (comment)

[DorraJaouad]

				if (key.includes('mention-call')) {
					message.message = message.message.replace(`{${key}}`, `@${mention.name}`)
				} else {
					message.message = message.message.replace(`{${key}}`, `@"${mention.id}"`)

				}

The double quotes " could solve mentions with id containing space and the other types remain rendered correctly.
For the at-all mention, we can just identify it by 'mention-call' and use name instead of rendering its token but it won't remain as a mention object in forward.

[nickvergessen]

For the at-all mention, we can just identify it by 'mention-call' and use name instead of rendering its token but it won't remain as a mention object in forward.

yes, that is actually the plan and okay.

Can be an issue thou if e.g. the room name starts with a user ID or the word "All", because then @Old room display name will actually create a mention with @old if the user exists.

[Antreesy]

Or we can avoid using @, just posting the Conversation name, maybe with bold markdown wrapping?

[DorraJaouad]

with bold markdown wrapping?

That might not be understood as a mention in the context. maybe also wrap it with double quotes ?
e.g : @"conversation name"

[nickvergessen]

That might not be read as a mention though.

Well the @all from the other room must not be a mention in the new room, so it would exactly match the desired behaviour.

maybe also wrap it with double quotes ?

That still renders mentions. We need to use it when the mention id conttains a space or slash. but for @all marking it bold sounds like a reasonable replacement.

[Antreesy]

Note: as it's a bug in 27 and below, do we consider backporting it? Requires manual backport, as logic was moved to store with feature PR

[nickvergessen]

It was a bug since such a long time and no one cared, so no backporting :)