fix(messagesStore) - Mentions in forwarded messages #10640
Conversation
DorraJaouad
added
bug
feature: chat 💬
There was a problem hiding this comment.
Tested with displayName.contains(id), displayName.contains(' '), displayName === id, and @all
Person will be notified with the forwarded message again, but should be expected (silent: false) and intended (if user forwards some tasks to internal chat, for example)
| @@ -1306,7 +1306,8 @@ const actions = { | |||
| for (const key in message.messageParameters) { | |||
| if (key.startsWith('mention')) { | |||
| const mention = message.messageParameters[key] | |||
| message.message = message.message.replace(`{${key}}`, `@${mention.name}`) | |||
| const mentionString = key.includes('mention-call') ? `**${mention.name}**` : `@"${mention.id}"` | |||
There was a problem hiding this comment.
Not sure it causes issues somewhere, but usually we only quote when a space or slash is contained in the id
There was a problem hiding this comment.
It also works for ids that do not contain spaces of slashes, maybe a specific use case I am not aware of?
There was a problem hiding this comment.
Maybe it's only on NcRichContenteditable
There was a problem hiding this comment.
Would be safe to copypaste that method with reference to the upstream component
…ntion to bold display name. Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/10631/fix-forwarded-mentions
branch
from
c0a693f to
edc7878
Compare
|
Backport to 27, now that we know it's only 2 lines of production code? |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist