Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📲 Add controller URL which opens directly the call/device checker #7038

Closed
nickvergessen opened this issue Mar 22, 2022 · 4 comments · Fixed by #10724
Closed

📲 Add controller URL which opens directly the call/device checker #7038

nickvergessen opened this issue Mar 22, 2022 · 4 comments · Fixed by #10724
Assignees

Comments

@nickvergessen
Copy link
Member

  • which opens browser and joins call

is this possible to directly join?

Originally posted by @tobiasKaminsky in nextcloud/desktop#4159 (comment)

@nickvergessen nickvergessen added this to the 💔 Backlog milestone Mar 22, 2022
@nickvergessen nickvergessen moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Mar 22, 2022
@camilasan
Copy link
Member

camilasan commented Mar 28, 2022

Since the desktop client is using the notifications to allow the user to interact with Talk, will the new urls be available as notification actions like DELETE, WEB...?

@tobiasKaminsky
Copy link
Member

Current notification already has a "join call" action.
You can simply use the url there.
Once this is implemented the url "just" changes on server side and directly joins call.

image

@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Aug 24, 2023
@nickvergessen nickvergessen changed the title Add controller URL which opens directly the call/device checker 📲 Add controller URL which opens directly the call/device checker Aug 29, 2023
@Antreesy Antreesy self-assigned this Aug 29, 2023
@Antreesy
Copy link
Contributor

After clarification call with Joas:

  • this is not going to be a new entrypoint (for creating an embedded window in Desktop client, for example)
  • notification link will be modified to contain a flag for direct opening of call (like ../call/{token}?direct_call)
  • navigating to this link will immediately shows MediaSettings dialog
  • optionally, forceJoinCall may be used to mount a CallView instead of ChatView (as we assuming that person wants to join call)

@nickvergessen
Copy link
Member Author

forceJoinCall may be used to mount a CallView instead of ChatView (as we assuming that person wants to join call)

As mentioned I don't think this is a good idea. If you had camera on last time and clicked away the media settings modal for ever, we would expose the user with camera and audio after following a link in an email and alike, so should require a confirmation via the media settings screen

@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💬 Talk team Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants