Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capabilities endpoint with openai translation integration #10317

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix capabilities endpoint with openai translation integration #10317

merged 3 commits into from
Sep 26, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 23, 2023 •
edited
Loading

☑️ Resolves

🚧 Tasks

🏁 Checklist

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client labels Aug 23, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Aug 23, 2023
@nickvergessen nickvergessen requested a review from Antreesy August 23, 2023 09:21
@nickvergessen nickvergessen changed the title Bugfix/10074/fix capabilities endpoint with openai translation integration Fix capabilities endpoint with openai translation integration Aug 23, 2023
Antreesy
Antreesy approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is compatible!
I've changed a way to receive language pairs: from capabilities to server request.
That means fetching them each time, but I doubt that it will have a big impact, then creating a dedicated store with reactivity for them

src/components/MessagesList/MessagesGroup/Message/Message.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/10074/fix-capabilities-endpoint-with-openai-translation-integration branch from 7b88c10 to d620a69 Compare September 26, 2023 14:30
@nickvergessen
fix(capabilities): Fix capability issues with OpenAI integration prov…
39d185f 
…iding too many translations

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(chat): Use new way to determinate if translations are available
7c1d6d5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/10074/fix-capabilities-endpoint-with-openai-translation-integration branch from 6588146 to 7c1d6d5 Compare September 26, 2023 14:32
This was referenced Sep 26, 2023
Closed
Closed
@Antreesy @nickvergessen
Fix getting translation sets in MessageTranslateDialog.vue
e19bf9b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@nickvergessen nickvergessen merged commit 5fc708d into master Sep 26, 2023
@nickvergessen nickvergessen deleted the bugfix/10074/fix-capabilities-endpoint-with-openai-translation-integration branch September 26, 2023 14:50
This was referenced Sep 27, 2023
Merged
Closed
Merged
@SystemKeeper SystemKeeper mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

@Antreesy Antreesy

Labels
2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Reduce size of capabilities response with translations enabled
2 participants
@nickvergessen @Antreesy