-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
techdebt(LoadingPlaceholder) - rewrite skeleton component #10489
Conversation
6bf22b0
to
577bb59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice from design perspective! 🚀
Does it also look good in dark mode? (was a problem until recently IIRC)...
Have updated screencasts for both dark and light themes, please see in the root description UPD: rebased onto master, increased wave width and speed a bit |
577bb59
to
fb1eef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's better than before 🦅. The animation looks fine and code-wise, it is more dynamic and concise. Just a tweak suggestion.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
fb1eef0
to
ec98f3a
Compare
Rebased onto master with post-review fix, no other changes |
/backport to stable27 |
☑️ Resolves
🖼️ Screenshots
🏚️ Before
Participants had different component as placeholder:
skeleton-pulse.webm
🏡 After
Animation flow:
skeleton-wave.webm
In normal colors:
skeleton-light-theme.webm
skeleton-dark-theme.webm
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required