Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ParticipantsTab) - virtual scrolling for participants list #10494

Merged
merged 3 commits into from
Sep 14, 2023
Merged

feat(ParticipantsTab) - virtual scrolling for participants list #10494

merged 3 commits into from
Sep 14, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

No visual changes

virtual.scroll.webm

🚧 Tasks

  • Code review
  • Manual testing

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Sep 12, 2023
@Antreesy Antreesy self-assigned this Sep 12, 2023
@Antreesy Antreesy requested a review from ShGKme September 14, 2023 10:02
DorraJaouad
DorraJaouad approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
add prop to define root node tag for Participant.vue
b63940a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
add ParticipantsListVirtual.vue component
affd2ce 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
ease DOM structure, fix styles
1ff6968 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/5907/virtual-scroll-participants branch from fbacef4 to 1ff6968 Compare September 14, 2023 12:26
@Antreesy
Copy link
Contributor Author

Rebased onto master, resolved conflicts and replace placeholders

@Antreesy Antreesy enabled auto-merge September 14, 2023 12:29
@Antreesy Antreesy merged commit 3aef38d into master Sep 14, 2023
23 checks passed
@Antreesy Antreesy deleted the fix/5907/virtual-scroll-participants branch September 14, 2023 14:19
@ShGKme
Copy link
Contributor

ShGKme commented Sep 14, 2023

Backport?

@Antreesy
Copy link
Contributor Author

Backport?

Yes, I've waited for placeholder backport

@Antreesy
Copy link
Contributor Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Stop using image-avatars in huge rooms
3 participants
@Antreesy @ShGKme @DorraJaouad