Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RightSidebar) - Optimize update active tab ( sharedItems) #10588

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Sep 25, 2023

Minimized fetch requests of shared Items
Regression from #10558
Part of #10559

🚧 Tasks

  • code review

@DorraJaouad DorraJaouad added regression feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Sep 25, 2023
@DorraJaouad DorraJaouad self-assigned this Sep 25, 2023
@DorraJaouad DorraJaouad changed the title Refactor RightSidebar and SharedItemsTab conditions fix(RightSidebar) - Optimize update active tab ( sharedItems) Sep 25, 2023
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

Let's also add a spinner to this component:

<template>
	<LoadingComponent v-if="loading" /> // should be aligned to center
	<div v-else>
	...
	</div>
</template>

@DorraJaouad DorraJaouad force-pushed the fix/noid/reduce-sharedItems-fetch branch from 0b5081e to fbeed68 Compare September 25, 2023 17:24
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/reduce-sharedItems-fetch branch from e360310 to e932eee Compare September 25, 2023 18:20
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@Antreesy Antreesy merged commit c5d6340 into master Sep 25, 2023
23 checks passed
@Antreesy Antreesy deleted the fix/noid/reduce-sharedItems-fetch branch September 25, 2023 18:26
@DorraJaouad
Copy link
Contributor Author

/backport to stable27

@DorraJaouad
Copy link
Contributor Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants