-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAvatar) increase avatar sizes in call #10610
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
color: #ffffff; | ||
background-color: #b9b9b9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing these static colors.
This is the view from Guest ( display name : pop )
And this is from a logged in user and Guest is present in the call ( display name : pop)
It would be nice if we use the same style for guest avatar from the user account view in the guest view ( make it always uppercase too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This identification method might be okay in other places like messages and participant lists because it doesn't own much of "visual weight" but for call view, it occupies more visual surface.
Alternative : Add "( guest )" to the display name to identify the guest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reference all this in follow-up issue =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 🦅
Avatar/space ratio looks better.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
4f59ec8
to
e4692fe
Compare
/backport to stable27 |
☑️ Resolves
avatar-mixin
is no longer used in components128 => 180
128 => 512
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required