Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Psalm): Move away from private and deprecated classes #10672

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 10, 2023

☑️ Resolves

  • Fix #…

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt labels Oct 10, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 10, 2023
@nickvergessen nickvergessen self-assigned this Oct 10, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/cleanup-psalm-exclusions branch from a44f0b5 to a57dbcb Compare October 10, 2023 09:50
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@@ -120,7 +120,7 @@ public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array
protected function makeOne2OneParticipantsOwners(array $one2oneRooms): int {
$update = $this->db->getQueryBuilder();

if (!$this->db->getDatabasePlatform() instanceof PostgreSQL94Platform) {
if (!$this->db->getDatabasePlatform() instanceof PostgreSQLPlatform) {
$update->update('spreedme_room_participants')
->set('participantType', $update->createNamedParameter(Participant::OWNER))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the casing is different by DB platform? 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well postgres is case sensitive, that's why we created a new table afterwards. 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤐

@nickvergessen nickvergessen merged commit 5a51d67 into master Oct 10, 2023
50 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/cleanup-psalm-exclusions branch October 10, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants