-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(LeftSidebar): Show hint when no filtered results #10679
Conversation
3906681
to
0a32442
Compare
0a32442
to
5587b00
Compare
5587b00
to
98c799d
Compare
407deb0
to
79eec40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to sqash commit, your first one was completely overwritten
79eec40
to
5ee5aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a last note (promise), how we can avoid going through the conversation list twice
Apart from that, looks and works nice!
5ee5aa7
to
fa9a200
Compare
…ogic. Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
fa9a200
to
427c636
Compare
☑️ Resolves
Hint
component was at the bottom of theLeftSidebar
because theConversationListVirtual
is always present at full height.The filtering logic :
"Standard Condition" : if conversation has call , mentions / unread message and is currently active in the chat view.
"Special Condition" : if conversation is currently active, the only one in the list and has no flag.
At the moment the filter is first applied:
After filters are applied (during subsequent filter navigation):
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist