Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): Render the actions and remove notification on click #10685

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

  • Fix #…

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
grafik Bildschirmfoto vom 2023-10-11 17-07-54

🛠️ API Checklist

🚧 Tasks

  • Make sure invite actions are shown and actionable
  • Immediately mark notifications as processed instead of on the next request due to missing invite object

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Oct 11, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 11, 2023
@nickvergessen nickvergessen self-assigned this Oct 11, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/5723/fix-remote-share-notifications branch from febf50a to a4f26cc Compare October 12, 2023 07:43
@nickvergessen nickvergessen merged commit a3009bb into master Oct 12, 2023
50 checks passed
@nickvergessen nickvergessen deleted the bugfix/5723/fix-remote-share-notifications branch October 12, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants