Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sharedItems): minor refactoring and style fixes #10720

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix(sharedItems): minor refactoring and style fixes #10720

merged 3 commits into from
Oct 17, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

@Antreesy
move NewMessageUploadEditor.vue up to parent component
1494ff2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix name overlapping for shared items tab
3b8e6e9 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
remove checks like 'message === {file}' or {object}'
9c86af4 
removed in favor of checking property existence
matches /file/ and /file.*/ for multiple files support

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Oct 16, 2023
@Antreesy Antreesy requested a review from DorraJaouad October 16, 2023 15:18
@Antreesy Antreesy self-assigned this Oct 16, 2023
DorraJaouad
DorraJaouad approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@Antreesy Antreesy merged commit 78215c9 into master Oct 17, 2023
35 checks passed
@Antreesy Antreesy deleted the fix/noid/shared-items-fixups branch October 17, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings technical debt
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad