Keep track of senders to allow unmutung with Safari #10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
feature: WebRTC 🚡
ShGKme
force-pushed
the
fix/fork-attachmediastream
branch
5 times, most recently
from
37fa4d4 to
3c7a908
Compare
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
fix/6094/safari-mute-unmute
branch
from
d5b061d to
bf576c5
Compare
|
Rebased after #10912 was merged. |
This was referenced Nov 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently based on
fix/fork-attachmediastreambranch!How to reproduce?
With
fix/fork-attachmediastream=> the UI shows as unmuted, but no audio is transmitted (most of the time)
With this PR:
=> Works
🏁 Checklist