Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LeftSidebar): Always show "create a new conversation" item #10952

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat(LeftSidebar): Always show "create a new conversation" item #10952

merged 1 commit into from
Nov 20, 2023

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

@DorraJaouad
feat(LeftSidebar): Always show "create a new conversation" item
2c2b0a3 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💔 Backlog milestone Nov 20, 2023
@DorraJaouad DorraJaouad requested a review from Antreesy November 20, 2023 14:14
@DorraJaouad DorraJaouad self-assigned this Nov 20, 2023
Antreesy
Antreesy approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Backport to 27?

@nickvergessen nickvergessen merged commit d6434b7 into main Nov 20, 2023
36 checks passed
@nickvergessen nickvergessen deleted the feat/10926/always-show-create-conversation-item branch November 20, 2023 15:44
@nickvergessen
Copy link
Member

Backport to 27?

No, it's a feature, fancy things only in 28+

@Antreesy Antreesy modified the milestones: 💔 Backlog, v18.0.0-rc.1 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review enhancement feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

"Create new conversation" only shows up if there is no match for existing rooms
3 participants
@DorraJaouad @nickvergessen @Antreesy